fix: add missing blob_id index to buffer_zones table#145
Open
RGB-loop wants to merge 1 commit intomemodb-io:mainfrom
Open
fix: add missing blob_id index to buffer_zones table#145RGB-loop wants to merge 1 commit intomemodb-io:mainfrom
RGB-loop wants to merge 1 commit intomemodb-io:mainfrom
Conversation
Add index on (blob_id, project_id) to BufferZone table to optimize: - JOIN queries between BufferZone and GeneralBlob - CASCADE DELETE performance when GeneralBlob records are deleted Without this index, cascade deletes would cause full table scans.
RGB-loop
requested review from
GenerQAQ,
gusye1234 and
jinjiaKarl
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
buffer_zonestable has a foreign key constraint on(blob_id, project_id)referencinggeneral_blobs, but there's no index on these columns.This causes:
general_blobsrecords are deletedBufferZoneandGeneralBlobSolution
Add index
idx_buffer_zones_blob_id_project_idon(blob_id, project_id)columns.Migration
After deploying, run the following SQL to add the index to existing databases:
CREATE INDEX idx_buffer_zones_blob_id_project_id
ON buffer_zones (blob_id, project_id);## Testing