Skip to content

Addition of absent meshery server API's #610

Open
YASHMAHAKAL wants to merge 10 commits intomeshery:masterfrom
YASHMAHAKAL:meshery-api
Open

Addition of absent meshery server API's #610
YASHMAHAKAL wants to merge 10 commits intomeshery:masterfrom
YASHMAHAKAL:meshery-api

Conversation

@YASHMAHAKAL
Copy link
Copy Markdown
Contributor

@YASHMAHAKAL YASHMAHAKAL commented Feb 12, 2026

Notes for Reviewers

This PR fixes #
Addition of absent constructs and refining meshery rest api's

Signed commits

  • Yes, I signed my commits.

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
…environment construct

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
@YASHMAHAKAL YASHMAHAKAL marked this pull request as draft February 12, 2026 10:46
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @YASHMAHAKAL, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands and refines Meshery's REST API definitions across several core domains. It introduces new API constructs for managing applications, patterns, and environments, alongside a suite of system-level endpoints for operational control. These additions aim to provide a more robust and comprehensive programmatic interface for Meshery's functionalities.

Highlights

  • New Application APIs: Introduced a comprehensive set of API endpoints for managing Meshery applications, covering retrieval, deletion, deployment, and type information.
  • Expanded Pattern APIs: Significantly extended the API surface for patterns, enabling operations like listing, creating, retrieving, deleting, deploying, cloning, and interacting with a pattern catalog.
  • Enhanced Environment Management APIs: Added new endpoints for full CRUD operations on environments and detailed management of connections within those environments.
  • Comprehensive System APIs: Implemented a broad range of new system-level API endpoints for managing adapters, database, files, events, Kubernetes configurations, and MeshSync resources.
Changelog
  • schemas/constructs/v1beta1/application/api.yml
    • Added a new OpenAPI specification for application management.
  • schemas/constructs/v1beta1/application/application.yaml
    • Added a new schema for the Meshery Application object.
  • schemas/constructs/v1beta1/connection/api.yml
    • Removed the "x-internal" tag from the PUT /api/connection/{id} endpoint.
  • schemas/constructs/v1beta1/design/api.yml
    • Added "PatternsAPI" tag to the Import Design endpoint.
    • Introduced new endpoints for pattern listing, creation, retrieval, deletion, deployment, cloning, catalog publishing/unpublishing, and downloads.
  • schemas/constructs/v1beta1/environment/api.yml
    • Added endpoints for environment retrieval, update, and deletion by ID.
    • Added endpoints for managing connections within a specific environment.
  • schemas/constructs/v1beta1/system/api.yml
    • Added a new OpenAPI specification for system-level operations, including adapter configuration, database management, file operations, event logging, Kubernetes context handling, and MeshSync resource querying.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new OpenAPI specifications for application and system APIs and refines existing ones for design, connection, and environment. My review has identified several indentation issues across the new and modified YAML files that could lead to parsing errors and inconsistencies. I've provided specific suggestions to correct these. Additionally, I've noted the use of placeholder schemas in the new API definitions, which should be replaced with concrete schema definitions to ensure correctness and maintainability.

Comment on lines +91 to +92
type: object
properties:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The indentation for type and properties is incorrect. It should be indented by two more spaces to be properly nested under schema.

              type: object
              properties:

Comment on lines +106 to +113
content:
multipart/form-data:
schema:
type: object
properties:
uploadYamlYmlFile:
type: string
format: binary
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Incorrect indentation in this requestBody block. Ensure consistent 2-space indentation.

        content:
          multipart/form-data:
            schema:
              type: object
              properties:
                uploadYamlYmlFile:
                  type: string
                  format: binary

Comment on lines +192 to +197
type:
type: string
supported_extensions:
type: array
items:
type: string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Incorrect indentation for type and supported_extensions. Maintain 2-space indentation relative to properties.

                    type:
                      type: string
                    supported_extensions:
                      type: array
                      items:
                        type: string

Comment on lines +260 to +263
url:
type: string
name:
type: string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Incorrect indentation for url and name type definitions. Ensure 2-space indentation relative to their parent property.

        url:
          type: string
        name:
          type: string

description: The source content of the application.
x-order: 7
type:
$ref: ../../v1alpha1/core/api.yml#/components/schemas/Text
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Incorrect indentation for $ref. It should be indented by 2 spaces relative to type for consistency.

    $ref: ../../v1alpha1/core/api.yml#/components/schemas/Text

Comment on lines +60 to +62
type: array
items:
type: string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation within this schema block is incorrect. Please adjust it to follow a consistent 2-space indentation.

            type: array
            items:
              type: string

Comment on lines +124 to +132
description: Successful
content:
application/json:
schema:
$ref: "#/components/schemas/MesheryPattern"
"404":
description: Pattern not found
"500":
description: Internal Server Error
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Incorrect indentation for these response definitions. Please ensure consistent 2-space indentation for readability and to prevent parsing issues.

          description: Successful
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/MesheryPattern"
        "404":
          description: Pattern not found
        "500":
          description: Internal Server Error

content:
application/json:
schema:
type: object # Placeholder for environmentResponseWrapper
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This API definition uses a placeholder schema (type: object # Placeholder for ...). While this might be acceptable for work in progress, it's crucial to replace these placeholders with actual schema definitions or references before this is considered complete. Using placeholders can lead to incorrect client generation and runtime errors. This comment applies to other placeholders in this file as well (lines 227, 273, 303).

content:
application/json:
schema:
type: object # Placeholder for systemDatabaseResponseWrapper
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This API definition uses a placeholder schema (type: object # Placeholder for ...). While this might be acceptable for work in progress, it's crucial to replace these placeholders with actual schema definitions or references before this is considered complete. Using placeholders can lead to incorrect client generation and runtime errors. This comment applies to other placeholders in this file as well.

Comment on lines +498 to +503
type:
type: integer
key:
type: string
value:
type: string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for the properties of AdapterOperation is incorrect. Please use a consistent 2-space indentation.

        type:
          type: integer
        key:
          type: string
        value:
          type: string

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
@YASHMAHAKAL YASHMAHAKAL marked this pull request as ready for review February 14, 2026 09:20
@YASHMAHAKAL YASHMAHAKAL changed the title Meshery api Addition of absent meshery server API's Feb 14, 2026
Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
description: Server error

post:
x-internal: ["cloud"]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed tags to make them both meshery and cloud api's

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
"500":
description: Server error

/api/integrations/connections/{connectionKind}:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks this is not valid current server only support get by connection ID

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixing

Signed-off-by: YASHMAHAKAL <yvsst01@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants