Conversation
Contributor
Author
|
Failing on deleted env tests: Will be rebased onto and landed after #443 |
allenwang28
approved these changes
Oct 17, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
==========================================
- Coverage 63.57% 63.48% -0.09%
==========================================
Files 77 77
Lines 7569 7526 -43
==========================================
- Hits 4812 4778 -34
+ Misses 2757 2748 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DNXie
pushed a commit
to DNXie/forge
that referenced
this pull request
Oct 20, 2025
photomz
pushed a commit
to photomz/forge
that referenced
this pull request
Oct 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled. Specifically removed:
interfaces.py: Environment, Policytypes.py: ForgeEnvInfo, Action, Trajectory, StateAlso
test_replay_bufferwas updated to use a locally definedTestEpisodeinstead of aTrajectorysince the test was the only caller ofTrajectory(and was using it more as a proxy forEpisodedue to the definition not being centralized)python -m pytest tests/unit_tests/test_replay_buffer.py::TestReplayBuffer