Skip to content

🌱 harden pr-verifier workflow trigger#1338

Merged
metal3-io-bot merged 1 commit into
metal3-io:release-1.11from
Nordix:tuomo/fix-pr-verifier-1.11
Mar 18, 2026
Merged

🌱 harden pr-verifier workflow trigger#1338
metal3-io-bot merged 1 commit into
metal3-io:release-1.11from
Nordix:tuomo/fix-pr-verifier-1.11

Conversation

@tuminoid

@tuminoid tuminoid commented Mar 16, 2026

Copy link
Copy Markdown
Member

This is needed to both fix the pr-verifier in branches (pull_request_target + permissions: {} = no op), but also to harden it by removing the target part.

@tuminoid
harden pr-verifier workflow trigger
5978448 
Signed-off-by: Tuomo Tanskanen <tuomo.tanskanen@est.tech>
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.11 milestone Mar 16, 2026
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2026
Sunnatillo
Sunnatillo reviewed Mar 16, 2026
View reviewed changes

@Sunnatillo Sunnatillo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026
smoshiur1237
smoshiur1237 reviewed Mar 16, 2026
View reviewed changes

@smoshiur1237 smoshiur1237 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tuminoid

tuminoid commented Mar 16, 2026

Copy link
Copy Markdown
Member Author

/cc @peppi-lotta @adilGhaffarDev @kashifest

@tuminoid

tuminoid commented Mar 16, 2026

Copy link
Copy Markdown
Member Author

/override metal3-centos-e2e-integration-test-release-1-11

@metal3-io-bot metal3-io-bot requested a review from kashifest March 16, 2026 10:00
@metal3-io-bot

metal3-io-bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-release-1-11

Details

In response to this:

/override metal3-centos-e2e-integration-test-release-1-11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@elfosardo

elfosardo commented Mar 16, 2026

Copy link
Copy Markdown
Member

/approve

adilGhaffarDev
adilGhaffarDev approved these changes Mar 17, 2026
View reviewed changes

@adilGhaffarDev adilGhaffarDev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tuminoid

tuminoid commented Mar 17, 2026

Copy link
Copy Markdown
Member Author

/approve

Bot missed it.
/cc @adilGhaffarDev

@adilGhaffarDev

adilGhaffarDev commented Mar 18, 2026

Copy link
Copy Markdown
Member

/approve

@metal3-io-bot

metal3-io-bot commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adilGhaffarDev, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2026
@metal3-io-bot metal3-io-bot merged commit 785313d into metal3-io:release-1.11 Mar 18, 2026
15 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/fix-pr-verifier-1.11 branch March 18, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sunnatillo Sunnatillo Sunnatillo left review comments

@smoshiur1237 smoshiur1237 smoshiur1237 left review comments

@peppi-lotta peppi-lotta Awaiting requested review from peppi-lotta

@kashifest kashifest Awaiting requested review from kashifest

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

IPAM - v1.11

Development

Successfully merging this pull request may close these issues.

6 participants

@tuminoid @metal3-io-bot @elfosardo @adilGhaffarDev @Sunnatillo @smoshiur1237
⚡