🐛 remove unused RBAC permissions for secrets

[tuminoid]

Remove the kubebuilder RBAC marker granting full CRUD on secrets. The controller never accesses secrets. Also remove the dead secret cache configuration and stale secretCachingClient comment from main.go.

[tuminoid]

/hold

[tuminoid]

/test ?

[tuminoid]

/test metal3-centos-e2e-feature-test-main-features
/test metal3-centos-e2e-feature-test-main-pivoting
/test metal3-centos-e2e-feature-test-main-remediation
/test metal3-centos-e2e-integration-test-main
/test metal3-ubuntu-e2e-integration-test-main

[tuminoid]

/cc @lentzi90 @adilGhaffarDev @kashifest

[lentzi90]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[adilGhaffarDev]

/lgtm

[tuminoid]

/unhold

[tuminoid]

/cherry-pick release-1.12
/cherry-pick release-1.11

[metal3-io-bot]

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-1.11, release-1.12 in new PRs and assign them to you.

Details

In response to this:

/cherry-pick release-1.12
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[metal3-io-bot]

@tuminoid: #1355 failed to apply on top of branch "release-1.11":

Applying: remove unused RBAC permissions for secrets
Using index info to reconstruct a base tree...
M	controllers/ippool_controller.go
M	main.go
Falling back to patching base and 3-way merge...
Auto-merging main.go
CONFLICT (content): Merge conflict in main.go
Auto-merging controllers/ippool_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 remove unused RBAC permissions for secrets

Details

In response to this:

/cherry-pick release-1.12
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[metal3-io-bot]

@tuminoid: #1355 failed to apply on top of branch "release-1.12":

Applying: remove unused RBAC permissions for secrets
Using index info to reconstruct a base tree...
M	controllers/ippool_controller.go
M	main.go
Falling back to patching base and 3-way merge...
Auto-merging main.go
CONFLICT (content): Merge conflict in main.go
Auto-merging controllers/ippool_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 remove unused RBAC permissions for secrets

Details

In response to this:

/cherry-pick release-1.12
/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.