Skip to content

fix duplicate spec.provider.oracle.auth.secret_ref.privatekey in exte…#112

Closed
antoniolago wants to merge 1 commit intometio:mainfrom
antoniolago:main
Closed

fix duplicate spec.provider.oracle.auth.secret_ref.privatekey in exte…#112
antoniolago wants to merge 1 commit intometio:mainfrom
antoniolago:main

Conversation

@antoniolago
Copy link
Copy Markdown

…rnal_secrets_io docs

@sebhoss
Copy link
Copy Markdown
Member

sebhoss commented Sep 24, 2023

Hey thanks for bringing this to my attention and even providing a fix for it!

Unfortunately I cannot merge this because it would break the current build process. At the moment the entire documentation is automatically generated using https://github.com/hashicorp/terraform-plugin-docs. The 'verify' pipeline will run this tool and check whether there are changes in the worktree. If it detects changes, the build will fail prompting the maintainers to re-run the documentation generation.

That said, the fix you provided is correct! I just need to investigate why the documentation generation does make a mistake here (and potentially elsewhere).

sebhoss added a commit that referenced this pull request Sep 24, 2023
Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
@sebhoss
Copy link
Copy Markdown
Member

sebhoss commented Sep 24, 2023

I'm still not sure why this is happening so I've created hashicorp/terraform-plugin-docs#285 to get some help.

@antoniolago
Copy link
Copy Markdown
Author

That makes sense 😅

I'll close this PR for now, but glad it brought light into this problem, I'll be following that issue, thank you so much.

Nice project btw.

sebhoss added a commit that referenced this pull request Mar 29, 2024
Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
sebhoss added a commit that referenced this pull request Mar 30, 2024
Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
@sebhoss
Copy link
Copy Markdown
Member

sebhoss commented Mar 31, 2024

I finally found some time to look deeper into this and opened hashicorp/terraform-plugin-docs#350 to fix this. I think this bug affects many providers in the ecosystem, so thanks again @antoniolago for opening this!

The latest version of this provider uses my patched version of terraform-plugin-docs and it seems to work as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants