Ignore primary constructors in MA0196 and reuse shared detection#1140
Merged
Conversation
Skip MA0196 diagnostics on primary constructors, whose XML docs belong to the containing type. Extract a shared IsPrimaryConstructor symbol helper and reuse it where primary-constructor detection was duplicated. Add regression tests and update MA0196 documentation to reflect the behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 8, 2026
Closed
This was referenced Jun 11, 2026
Open
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0196 should not flag
<inheritdoc />attached to primary constructor syntax, because that XML documentation primarily describes the containing type. This change fixes that false positive and consolidates primary-constructor detection logic.What changed
IsPrimaryConstructorhelper inSymbolExtensions.InheritdocShouldBeUsedOnInheritingMemberAnalyzerPrimaryConstructorParameterShouldBeReadOnlyAnalyzerLocalVariablesShouldNotHideSymbolsAnalyzerNotes
includeRecordDeclarations: truein the shared helper to cover record primary constructors.roslyn4.2androslyn4.14.Fix #1139