Allow cref in MA0197 inheritdoc checks#1142
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Revert accidental SDK/MSBuild SDK updates and restore nullable warning settings for net462. Also split InheritdocShouldNotBeUsedOnTypesAnalyzerTests into a matching file to satisfy MA0048 and keep the new cref test coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 8, 2026
Closed
This was referenced Jun 11, 2026
Open
This was referenced Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MA0197 currently flags
<inheritdoc>on types even when acrefis provided, which prevents using explicit documentation inheritance targets on type declarations.This update makes MA0197 consistent with that usage by skipping diagnostics when
<inheritdoc>includes acrefattribute. The analyzer now handles both empty XML tags (<inheritdoc cref="..." />) and non-empty XML tags (<inheritdoc cref="..."></inheritdoc>). The rule tests were updated to assert the new behavior, and the MA0197 documentation now reflects thatcrefis allowed.This branch also includes the existing dependency/tooling update commit already present on this branch (
global.jsonSDK/MSBuild SDK updates and aDirectory.Build.targetsadjustment for nullable warning suppression scope).