Skip to content

Improve bill logging #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfosterw merged 1 commit into from
Mar 3, 2026
Merged

Improve bill logging #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions democrasite/webiscite/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,14 @@ class Meta:
def __str__(self) -> str:
return f"Bill {self.id}: {self.name} ({self.pull_request})"

def log(self, msg, *args):
logger.info(f"Bill %s (#%s): {msg}", self.id, self.pull_request.number, *args) # noqa: G004
def log(self, msg, *args, level=logging.INFO):
logger.log(
level,
f"Bill %s (#%s): {msg}", # noqa: G004
self.id,
self.pull_request.number,
*args,
)
# f-string necessary to let string interpolation work in msg

def get_absolute_url(self) -> str:
Expand Down
4 changes: 3 additions & 1 deletion democrasite/webiscite/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
from :func:`democrasite.webiscite.webhooks`.
"""

from logging import WARNING

import requests
from celery import shared_task
from celery.utils.log import get_task_logger
Expand Down Expand Up @@ -47,7 +49,7 @@ def submit_bill(bill_id: int) -> None:
if merged:
bill.log("Merged")
else:
logger.warning("Bill %s failed to merge", bill.id)
bill.log("Failed to merge", level=WARNING)
return

# Automatically update constitution line numbers if necessary
Expand Down
⚡