Skip to content

Fix API Crash#318

Merged
mfosterw merged 1 commit intomainfrom
api-crash
Mar 17, 2026
Merged

Fix API Crash#318
mfosterw merged 1 commit intomainfrom
api-crash

Conversation

@mfosterw
Copy link
Copy Markdown
Owner

And add regression test. I added an assert to silence a mypy error without realizing that the type error wouldn't cause a crash but the assert would.

@mfosterw mfosterw merged commit 402f3f4 into main Mar 17, 2026
2 checks passed
@mfosterw mfosterw deleted the api-crash branch March 17, 2026 21:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9d46620) to head (03bb2d1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2019      2017    -2     
=========================================
- Hits          2019      2017    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant