Skip to content

Inconsistent documentation for config validation #647

@crondaemon

Description

@crondaemon

Describe the bug
The documentation states

assert SidekiqUniqueJobs.validate_worker!(BadWorker.get_sidekiq_options)

in the minitest section. Hoever, the code is

raise InvalidWorker, lock_config unless lock_config.errors.empty?

this would require assert_nothing_raised or similar to be used.

Expected behavior
A failing test should gently say the test is not passed.

Current behavior
The test crashes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions