Don't skip monkeypatches if ActiveSupport present#248
Merged
mhenrixon merged 1 commit intomhenrixon:masterfrom Oct 17, 2017
Merged
Don't skip monkeypatches if ActiveSupport present#248mhenrixon merged 1 commit intomhenrixon:masterfrom
mhenrixon merged 1 commit intomhenrixon:masterfrom
Conversation
sidekiq-unique-jobs needs a small number of methods from active support. It contains some vendored methods in case ActiveSupport isn't present. Currently those methods are only added if ActiveSupport is _nowhere Ruby's the load path_. This breaks in the following cases: - ActiveSupport is being used the application but only a subset of methods are included. - ActiveSupport is present in the load path but is not being used as part of the application. This removes the check on whether ActiveSupport is loadable. This should solve all cases.
Owner
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: removes two superfluous-seeming checks in core_ext that cause breakage if ActiveSupport is in the require path but not fully loaded.
sidekiq-unique-jobs needs a small number of methods from ActiveSupport. It vendors these methods in case ActiveSupport isn't present.
Currently those methods are only added if ActiveSupport is nowhere Ruby's require path. This breaks in the following cases:
This removes the check on whether ActiveSupport is loadable. The solves the above two cases , while still not avoiding re-adding methods in the case that ActiveSupport has already added them.