Log job silently complete#371
Merged
mhenrixon merged 2 commits intomhenrixon:masterfrom Feb 23, 2019
Merged
Conversation
Borrows heavily from mhenrixon#320 with the objective to get it shipped. The problem, as described, is that on a surface a job successfully completes where in fact it wasn't executed at all, due to a lock. This commit adds some clarity in the form of a log message explaining that the job did complete silently.
tadejm
force-pushed
the
log-when-job-silently-ignored
branch
from
d2ec744 to
00a6fd5
Compare
* Spacing and alignment * Alphabetical order in gemspec
Owner
|
Awesome! Thanks for the contribution and the added clarity. Sent with GitHawk |
Contributor
Author
|
Thank you for providing this gem, really useful kit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Borrows heavily from #320
with the objective to get this highly useful log shipped to master.
The problem, as described, is that on a surface a job successfully completes where in fact it wasn't executed at all, due to a lock.
This commit adds some clarity in the form of a log message explaining that the job did complete silently.
For more info check #320 (comment)