Allow Sidekiq::Context to be used for logging#429
Merged
Conversation
Memoize the method for context aware logging to avoid those lookups everytime.
mhenrixon
force-pushed
the
fix-logging-with-sidekiq-6.0.1
branch
from
df28e0c to
00e0ebf
Compare
It really slows down time to release and I don't have the patience. Let's just assume that if one sidekiq version works, the others will too.
This avoids having all if statements in the same method which reads nicer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memoize the method for context aware logging to avoid those lookups everytime.