Skip to content

Update gemspec: thor#465

Merged
mhenrixon merged 2 commits intomhenrixon:masterfrom
masawo:gemspec-thor
Mar 18, 2020
Merged

Update gemspec: thor#465
mhenrixon merged 2 commits intomhenrixon:masterfrom
masawo:gemspec-thor

Conversation

@masawo
Copy link
Copy Markdown
Contributor

@masawo masawo commented Jan 7, 2020

Now, the thor gem is version 1.0.1.

On my repository, using sidekiq-unique-jobs, I tried to update thor gem, but its version stayed the same.

To resolve this, I modified .gemspec file with reference to an other repository below:
https://github.com/rails/jquery-rails/blob/master/jquery-rails.gemspec#L19

@mhenrixon mhenrixon self-assigned this Jan 7, 2020
@jpalumickas
Copy link
Copy Markdown

Any updates on this one?

Copy link
Copy Markdown
Owner

@mhenrixon mhenrixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all for the patience! This one completely dropped from my radar...

Hopefully, the new Github iOS app will help prevent future such problems.

@mhenrixon mhenrixon merged commit 40db285 into mhenrixon:master Mar 18, 2020
@jpalumickas
Copy link
Copy Markdown

Thank you ! 🎉

@masawo masawo deleted the gemspec-thor branch March 24, 2020 11:41
replaid added a commit to RosieApp/sidekiq-unique-jobs that referenced this pull request Jun 19, 2020
mhenrixon pushed a commit that referenced this pull request Jun 23, 2020
JureCindro added a commit to BookingSync/sidekiq-unique-jobs that referenced this pull request Nov 9, 2022
sjaime added a commit to bebanjo/sidekiq-unique-jobs that referenced this pull request Nov 19, 2024
This is a backport of mhenrixon#465
on top of v5.0.11

This allows to install 5.0.11 on a Rails 6.1 app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants