Skip to content

Fix errors_as_string on lock_config.rb#469

Merged
mhenrixon merged 1 commit intomhenrixon:masterfrom
donaldpiret:patch-1
Feb 7, 2020
Merged

Fix errors_as_string on lock_config.rb#469
mhenrixon merged 1 commit intomhenrixon:masterfrom
donaldpiret:patch-1

Conversation

@donaldpiret
Copy link
Copy Markdown
Contributor

Was getting the following error message when trying to validate options:

 Failure/Error: specify { expect(described_class).to have_valid_sidekiq_options }
 
 NameError:
   undefined local variable or method `lock_config' for #<SidekiqUniqueJobs::LockConfig:0x00007fdc90af1008>
   Did you mean?  lock_info

 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/sidekiq-unique-jobs-7.0.0.beta9/lib/sidekiq_unique_jobs/lock_config.rb:78:in `errors_as_string'
 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/sidekiq-unique-jobs-7.0.0.beta9/lib/sidekiq_unique_jobs/rspec/matchers/have_valid_sidekiq_options.rb:29:in `failure_message'
 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:35:in `handle_failure'
 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
 # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/expectation_target.rb:65:in `to'
 # ./spec/workers/poller_worker_spec.rb:14:in `block (2 levels) in <top (required)>'

Was getting the following error message when trying to validate options:

     Failure/Error: specify { expect(described_class).to have_valid_sidekiq_options }
     
     NameError:
       undefined local variable or method `lock_config' for #<SidekiqUniqueJobs::LockConfig:0x00007fdc90af1008>
       Did you mean?  lock_info

     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/sidekiq-unique-jobs-7.0.0.beta9/lib/sidekiq_unique_jobs/lock_config.rb:78:in `errors_as_string'
     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/sidekiq-unique-jobs-7.0.0.beta9/lib/sidekiq_unique_jobs/rspec/matchers/have_valid_sidekiq_options.rb:29:in `failure_message'
     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:35:in `handle_failure'
     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:50:in `block in handle_matcher'
     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:27:in `with_matcher'
     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/handler.rb:48:in `handle_matcher'
     # /Users/dpiret/.asdf/installs/ruby/2.6.3/lib/ruby/gems/2.6.0/gems/rspec-expectations-3.9.0/lib/rspec/expectations/expectation_target.rb:65:in `to'
     # ./spec/workers/poller_worker_spec.rb:14:in `block (2 levels) in <top (required)>'
Copy link
Copy Markdown
Owner

@mhenrixon mhenrixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How embarrassing 🤫

@mhenrixon mhenrixon self-assigned this Feb 7, 2020
@mhenrixon mhenrixon added this to the V7.0 milestone Feb 7, 2020
@mhenrixon mhenrixon merged commit 69248f6 into mhenrixon:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants