Refactoring connectors to use them in client and server#56
Merged
mhenrixon merged 1 commit intomhenrixon:masterfrom Nov 3, 2014
Merged
Conversation
salrepe
changed the title
salrepe
force-pushed
the
refactorize-to-use-connectors-in-client-and-server
branch
from
c6e6f31 to
a6b00cd
Compare
Owner
|
That was painful but I got it merged at last. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After implement pull request #53 I realized that we could extract more the connectors to use them in client and server without repeating logic.