Pass lock timeout to primed_async#624
Merged
mhenrixon merged 1 commit intomhenrixon:masterfrom Jul 21, 2021
Merged
Conversation
relates to mhenrixon#617 There is an issue where an integer `config.timeout` was being respected in `pop_queued`, but the promise in `primed_async` was only waiting the `config.ttl` plus the drift. This means that high latency redis connections will return a `nil` `primed_jid` and while_executing jobs will get dropped. The proposed solution is to ensure that `config.timeout` gets passed in as the `wait` argument to the bound `method(:primed_async)`, which allows the `Concurrent::Promises` to timeout after the same duration (plus drift) as the `brpoplpush` call. The issue triage and approach is documented in: - mhenrixon#617 (comment) - mhenrixon#617 (comment) - mhenrixon#617 (comment)
Closed
mhenrixon
approved these changes
Jul 20, 2021
Owner
mhenrixon
left a comment
mhenrixon
left a comment
There was a problem hiding this comment.
Stellar research and stellar implementation! I'll get this released as soon as possible!
I have been staring at this problem for so long without understanding what could possibly be wrong.
Contributor
Author
|
Thanks and thanks for the great gem!! |
Owner
mhenrixon
added a commit
that referenced
this pull request
Jul 28, 2021
Locking mechanism was broken in #624.
mhenrixon
added a commit
that referenced
this pull request
Jul 28, 2021
* Fix UntilAndWhileExecuting Locking mechanism was broken in #624. * Bump appraisals * Simplify access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #617
There is an issue where an integer
config.timeoutwas beingrespected in
pop_queued, but the promise inprimed_asyncwas onlywaiting the
config.ttlplus the drift.This means that high latency redis connections will return a
nilprimed_jidand while_executing jobs will get dropped.The proposed solution is to ensure that
config.timeoutgets passed inas the
waitargument to the boundmethod(:primed_async), whichallows the
Concurrent::Promisesto timeout after the same duration(plus drift) as the
brpoplpushcall.The issue triage and approach is documented in: