fix(after_unlock): regression from #707#737
Merged
mhenrixon merged 2 commits intomhenrixon:mainfrom Dec 3, 2022
Merged
Conversation
BACKGROUND ------------------------------------------------------------- mhenrixon#707 introduced a regression where the instance level `after_unlock` callback is no longer being called. This was due to the change of using `item[CLASS]` instead of `worker_class` to set `job_class` in `SidekiqUniqueJobs::Middelware#call`. `item[CLASS]` is a string, where as `worker_class` can be either an instance, or the class itself. For the instance level `after_unlock` to work, we need `job_class` to be an instance of the worker. This fixes the issue by switching back to setting `job_class` to `worker_class` CHANGELOG -------------------------------------------------------------- - Use worker_class for self.job_class in Middleware#call
Owner
|
Hi @adamcreekroad, I updated your branch with the latest changes to make sure the CI results are fair to your change. Please fix any issues remaining, and I'll merge and release your PR as well. Thank you for your contribution. |
mhenrixon
changed the title
mhenrixon
changed the title
mhenrixon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
#707 introduced a regression where the instance level
after_unlockcallback is no longer being called. This was due to the change of usingitem[CLASS]instead ofworker_classto setjob_classinSidekiqUniqueJobs::Middelware#call.item[CLASS]is a string, where asworker_classcan be either an instance, or the class itself. For the instance levelafter_unlockto work, we needjob_classto be an instance of the worker.This fixes the issue by switching back to setting
job_classtoworker_classChangelog