fix(digests): ensure consistent digests#743
Merged
Conversation
mhenrixon
force-pushed
the
fix/consistent-digests
branch
from
6cd8a2a to
4579f88
Compare
mhenrixon
force-pushed
the
fix/consistent-digests
branch
from
4579f88 to
a652ca9
Compare
mhenrixon
force-pushed
the
fix/consistent-digests
branch
from
2b93830 to
5f60542
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems plausible that the order of the digest could be different between here. There should have been more broken tests unless the order of the digestable_hash keys sometimes ended up out of order.
Closes #739