Add lock to item when lock_type is pulled from Job class sidekiq options#786
Merged
mhenrixon merged 2 commits intomhenrixon:mainfrom May 27, 2023
Conversation
For jobs that are queued without the lock options, to a Job class that has `lock` option set in the `sidekiq_options` will still go through the SidekiqUniqueJobs server middleware, but won't have `lock` set on the item the entire time. This doesn't seem to be affecting the locking or unlocking of jobs, however it is affecting the logging_context because the Middleware LogContext expects the item[LOCK] to have a value.
ttstarck
force-pushed
the
logging_context_bug_with_jobs_not_queued_with_lock
branch
from
99c8610 to
cfe59ea
Compare
mhenrixon
approved these changes
May 27, 2023
Owner
mhenrixon
left a comment
mhenrixon
left a comment
There was a problem hiding this comment.
Brilliant! Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#785