Skip to content

Support for Sidekiq 8#866

Merged
mhenrixon merged 1 commit intomhenrixon:mainfrom
jukra:sidekiq8
Feb 19, 2025
Merged

Support for Sidekiq 8#866
mhenrixon merged 1 commit intomhenrixon:mainfrom
jukra:sidekiq8

Conversation

@jukra
Copy link
Copy Markdown
Contributor

@jukra jukra commented Feb 12, 2025

This pull request introduces support for the refactored web UI in Sidekiq 8, while trying to maintain backward compatibility with earlier versions.

Key Changes

  1. Added conditional logic for web helpers to support both the old and new implementation. Changed the names of few methods to avoid conflicts (safe_*)
  2. New initialisation code for the web extension for Sidekiq 8
  3. Test setup for Sidekiq 8

This still needs more testing, and ofc the official release of Sidekiq 8

@jukra
Copy link
Copy Markdown
Contributor Author

jukra commented Feb 19, 2025

Removed the previous formatting change from lock_args_spec.rb which failed the specs in GitHub actions

@mhenrixon mhenrixon merged commit fdfc15e into mhenrixon:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants