Remove redundant include to locales (for Sidekiq 8)#867
Merged
mhenrixon merged 2 commits intomhenrixon:mainfrom Feb 27, 2025
Merged
Remove redundant include to locales (for Sidekiq 8)#867mhenrixon merged 2 commits intomhenrixon:mainfrom
mhenrixon merged 2 commits intomhenrixon:mainfrom
Conversation
mhenrixon
approved these changes
Feb 26, 2025
Contributor
Author
|
Thanks for the review! @mhenrixon could you merge this? I think the failing ci for rubocop should be fixed in a separate PR, as it looks like to be about outdated config in general? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generates errors for Sidekiq 8, and looks like this gem does not have any translation files, so it can be just removed?
Edit: Also added Sidekiq 8 to Github workflows