fix(lua): replace deprecated global arg with {...} in log_debug#937
fix(lua): replace deprecated global arg with {...} in log_debug#937
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 11 minutes and 58 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFixed a Lua compatibility bug where the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
The `arg` implicit table for variadic function arguments was removed in
Lua 5.2+. Redis 7+ and Dragonfly use newer Lua versions that don't
support this global, causing errors when debug_lua is enabled.
Replace `ipairs(arg)` with `ipairs({...})` which works across all Lua
versions.
Closes #877
8983b6e to
5e5bd56
Compare
Summary
argtable for variadic function arguments was removed in Lua 5.2+argglobalipairs(arg)toipairs({...})inlog_debug, which works across all Lua versionsCloses #877
Test plan
Summary by CodeRabbit