fix(ui): use row locale for extraction preview phone formatting (#886)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: cpcloud

internal/app/extraction_render.go

@@ -830,6 +830,26 @@ func groupOperationsByTable(ops []extract.Operation, cur locale.Currency) []prev
 			keyByTitle[d.spec.Title] = d.dataKey
 		}
 
+		// For vendor rows with a locale, override the phone formatter
+		// to use the row-level locale instead of the system default.
+		if op.Table == data.TableVendors {
+			if loc, _ := op.Data[data.ColLocale].(string); loc != "" {
+				for _, d := range allDefs {
+					if d.dataKey == data.ColPhone {
+						region := strings.ToUpper(loc)
+						fmtByTitle[d.spec.Title] = func(v any) string {
+							s, ok := v.(string)
+							if !ok || s == "" {
+								return fmtAnyText(v)
+							}
+							return locale.FormatPhoneNumber(s, region)
+						}
+						break
+					}
+				}
+			}
+		}
+
 		row := make([]cell, len(g.specs))
 		for i, spec := range g.specs {
 			key := keyByTitle[spec.Title]

internal/app/extraction_render_test.go

@@ -7,6 +7,7 @@ import (
 	"testing"
 
 	"github.com/micasa-dev/micasa/internal/data"
+	"github.com/micasa-dev/micasa/internal/extract"
 	"github.com/micasa-dev/micasa/internal/locale"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
@@ -34,3 +35,49 @@ func TestPreviewColumnsVendorFormatsPhone(t *testing.T) {
 	assert.Equal(t, "(555) 123-4567", phoneFmt("5551234567"))
 	assert.Equal(t, "not a phone", phoneFmt("not a phone"))
 }
+
+func TestGroupOperationsByTableUsesRowLocale(t *testing.T) {
+	// Not parallel: t.Setenv modifies process-global state.
+	t.Setenv("LC_ALL", "en_US.UTF-8")
+	cur, err := locale.ResolveDefault("")
+	require.NoError(t, err)
+
+	ops := []extract.Operation{
+		{
+			Action: extract.ActionCreate,
+			Table:  data.TableVendors,
+			Data: map[string]any{
+				data.ColName:   "UK Plumber",
+				data.ColPhone:  "02079460958",
+				data.ColLocale: "GB",
+			},
+		},
+		{
+			Action: extract.ActionCreate,
+			Table:  data.TableVendors,
+			Data: map[string]any{
+				data.ColName:  "US Plumber",
+				data.ColPhone: "5551234567",
+			},
+		},
+	}
+
+	groups := groupOperationsByTable(ops, cur)
+	require.Len(t, groups, 1)
+	require.Len(t, groups[0].cells, 2)
+
+	// Find phone column index.
+	phoneIdx := -1
+	for i, spec := range groups[0].specs {
+		if spec.Title == "Phone" {
+			phoneIdx = i
+			break
+		}
+	}
+	require.NotEqual(t, -1, phoneIdx, "phone column not found")
+
+	// UK vendor should use GB locale formatting.
+	assert.Equal(t, "020 7946 0958", groups[0].cells[0][phoneIdx].Value)
+	// US vendor (no locale) should fall back to system default (US).
+	assert.Equal(t, "(555) 123-4567", groups[0].cells[1][phoneIdx].Value)
+}

internal/app/vendor_test.go

@@ -218,23 +218,33 @@ func TestVendorLocalePreservedOnEdit(t *testing.T) {
 		Locale: "GB",
 	}))
 
-	vendors, err := m.store.ListVendors(false)
-	require.NoError(t, err)
-	require.Len(t, vendors, 1)
-	id := vendors[0].ID
+	// Navigate to vendor tab and reload.
+	for i, tab := range m.tabs {
+		if tab.Kind == tabVendors {
+			m.active = i
+			break
+		}
+	}
+	require.NoError(t, m.reloadActiveTab())
+	tab := m.activeTab()
+	require.NotEmpty(t, tab.Rows)
+	tab.Table.SetCursor(0)
+	id := tab.Rows[0].ID
 
-	// Open the real edit form -- this calls vendorFormValues(vendor)
-	// which copies Locale from the DB record into formData.
-	require.NoError(t, m.startEditVendorForm(id))
-	m.fs.form.Init()
+	// Open edit form via keypresses.
+	sendKey(m, "i")
+	tab.ColCursor = int(vendorColID)
+	sendKey(m, "e")
+	require.Equal(t, modeForm, m.mode, "should open full edit form")
 
-	// Change the name through the form data (simulates user editing).
+	// Change the name through the form data.
 	values, ok := m.fs.formData.(*vendorFormData)
 	require.True(t, ok)
 	values.Name = "UK Plumber Renamed"
 
-	// Submit -- parseVendorFormData carries Locale through.
-	require.NoError(t, m.submitVendorForm())
+	// Submit via keypress.
+	sendKey(m, "ctrl+s")
+	sendKey(m, "esc")
 
 	// Reload and verify Locale is preserved.
 	updated, err := m.store.GetVendor(id)
@@ -273,10 +283,11 @@ func TestVendorInlineEditPhoneUsesRawValue(t *testing.T) {
 	phoneCell := tab.CellRows[0][int(vendorColPhone)]
 	assert.Equal(t, "020 7946 0958", phoneCell.Value, "table should show formatted phone")
 
-	id := tab.Rows[0].ID
-
-	// Open inline edit for phone column.
-	require.NoError(t, m.inlineEditVendor(id, vendorColPhone))
+	// Open inline edit for phone column via keypresses.
+	tab.Table.SetCursor(0)
+	sendKey(m, "i")
+	tab.ColCursor = int(vendorColPhone)
+	sendKey(m, "e")
 	require.NotNil(t, m.inlineInput)
 
 	// The inline input should contain the raw DB value, not the formatted one.