fix(ui): use row locale for extraction preview phone formatting#886
Merged
cpcloud merged 2 commits intomicasa-dev:mainfrom Apr 1, 2026
Merged
fix(ui): use row locale for extraction preview phone formatting#886cpcloud merged 2 commits intomicasa-dev:mainfrom
cpcloud merged 2 commits intomicasa-dev:mainfrom
Conversation
The extraction preview was formatting vendor phone numbers with the system's detected country instead of the vendor's locale. Override the phone formatter per-row when the extracted data includes a locale. Also rewrite vendor edit tests to drive through keypresses (sendKey) instead of calling startEditVendorForm/inlineEditVendor directly, matching the project's user-interaction test conventions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add TestGroupOperationsByTableUsesRowLocale to verify that vendor extraction previews use the row's locale for phone formatting instead of the system default, and that rows without a locale fall back correctly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
020 7946 0958instead of US-formatted outputsendKey) instead of callingstartEditVendorForm/inlineEditVendordirectlyTestGroupOperationsByTableUsesRowLocalecovering the row-level locale override and fallback to system default