Skip to content

Commit 91ff337

Browse files
committed
ci(vendor-hash): drop vendor-hash-check from SKIP
Once indirect majors are blocked at the Renovate layer, every remaining Renovate PR that reaches this workflow bumps a module in place. go.sum changes and vendor content changes together, so the computed vendorHash moves with go.sum and nix/package.nix is always staged with a real diff. vendor-hash-check then has both files staged and exits 0 on its own. Suppressing it was papering over the symptom of the scenario that rule was added to eliminate. If the hook ever fires again from inside this workflow, that is a real invariant break worth investigating, not something to silence.
1 parent d414d2f commit 91ff337

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

.github/workflows/update-vendor-hash.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,6 @@ jobs:
128128
run: nix build '.#micasa' --no-link -L
129129

130130
- name: Commit and push
131-
env:
132-
# vendor-hash-check fires when go.sum is staged but nix/package.nix
133-
# is not, which is exactly the state when `go mod tidy` reshapes
134-
# go.sum without altering vendor contents. The compute step above
135-
# already ran the authoritative nix build, so this hook has nothing
136-
# to add here.
137-
SKIP: vendor-hash-check
138131
run: |
139132
git config user.name "github-actions[bot]"
140133
git config user.email "github-actions[bot]@users.noreply.github.com"

0 commit comments

Comments
 (0)