fix(ux): stabilize explore mode toggle visuals in extraction overlay#931
Merged
cpcloud merged 5 commits intomicasa-dev:mainfrom Apr 18, 2026
Merged
fix(ux): stabilize explore mode toggle visuals in extraction overlay#931cpcloud merged 5 commits intomicasa-dev:mainfrom
cpcloud merged 5 commits intomicasa-dev:mainfrom
Conversation
cpcloud
force-pushed
the
worktree-agent-af040029
branch
2 times, most recently
from
d09f00b to
ab9b77f
Compare
Root cause analysis and implementation plan for the two visual glitches when toggling explore mode: hint bar key jumping and overlay height changes from varying preview tab row counts. closes micasa-dev#892
Three fixes for visual jumping when toggling explore mode (micasa-dev#892): 1. Reorder pipeline-mode hints so a/x/esc are always the trailing three items, matching explore mode. Mode-specific hints (enter, t/layout) come before the stable tail. 2. Compute preview line reservation from the tallest tab's row count and pad the rendered section to that height, preventing the overlay from shrinking when switching between tabs with different row counts. 3. Use ex.previewTab in both modes instead of resetting to tab 0 in pipeline mode, maintaining visual continuity across toggle. closes micasa-dev#892
When all operations target unknown tables, groupOperationsByTable returns empty groups but hasOps is true. Fall back to rendered section line count instead of returning 0 from stablePreviewLines, preserving overlay sizing behavior for this edge case.
- Replace string concat loop with strings.Repeat (perfsprint) - Use require.Positive/assert.Positive instead of Greater(x, 0) (testifylint) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cpcloud
force-pushed
the
worktree-agent-af040029
branch
2 times, most recently
from
f31356f to
77f304e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
a/x/escnow always appear as trailing group in both pipeline and explore modes — mode-specific hints precede themstablePreviewLines()reserves height from tallest tab across all preview groups, padding shorter tabs with newlinesReproduction steps
a/x/escin hint bar and overlay heightxto toggle explore modeChanges
internal/app/extraction_render.go— hint bar reorder,stablePreviewLines(), tab persistence, unknown-table fallbackinternal/app/extraction_test.go— 5 new tests covering all fix behaviorsCloses #892
🤖 Generated with Claude Code