Conversation
|
|
||
| public submit = () => { | ||
| var msg = new Models.OrderRequestFromUI(this.side, this.price, this.quantity, this.timeInForce, this.orderType); | ||
| this._log.info("submitting order", msg); |
There was a problem hiding this comment.
Why are you getting rid of the client-side logging?
There was a problem hiding this comment.
this is not related to the full space of the vmdk of docker, but instead is to minimize the traffic of the application. I preffer the app to send data to the exchange api rathen than to the client (if that msg to the client is just a notice of an action already known by the client by other means [rich gui]).
Also, users do not look at the console; if this is for devs, let devs activate (uncomment) this stream of debuggin data when needed rather than force all users to transmit it..
if you dont agree i can uncomment it in a next commit easy 😊
There was a problem hiding this comment.
I'm not following the first paragraph "this is not related to the full space of the vmdk of docker...".
The logging is for development but if you'd like the ability to eliminate it, I'd prefer either
a) Changing it to Debug level then using logProvider (https://docs.angularjs.org/api/ng/provider/$logProvider) to turn it off
a) Wholly remove it, don't leave the commented version around.
There was a problem hiding this comment.
thanks! marked as TODO soon
Restored logs at 54ab3f6 (still need to try option A)
about the vmdk of docker comment, i found the hard disk of my virtual boxes completely full after a few days of run.
ctubio
force-pushed
the
boomerang
branch
2 times, most recently
from
585c66c to
311c0a9
Compare
4 participants
Hello michael''
here is a new quoting mode like PingPong but taking into account not only the last trade but also all other previous trades still opened.
A trade is considered opened once it is done, and will remain as opened until another matching trade of the opposite side plus the margin of the width is also done. Then both trades are merged and flagged as closed.
Closed trades as well as the whole history of trades can be cleaned using ui buttons.
Also the ui features optional audio and the size input was split into two inputs: buySz and sellSz.
Message table is not displayed anymore and market_display table took over its space.
Included in this PR, is also #74 and #75, and a major silent of console.log and filesystem log messages (together with truncated database collections to 1 single record [less than trades collection, that is unlimited and is loaded all at startup without limit by start_time]) to avoid hitting the limit of the harddisk after 2 hours of run.
Sorry for the horrible commit messages, i didnt expected for this to be shared, but here it comes!