Adds an upload definitions method to upload the definitions#220
Merged
michaelklishin merged 8 commits intomichaelklishin:masterfrom Dec 12, 2021
Merged
Adds an upload definitions method to upload the definitions#220michaelklishin merged 8 commits intomichaelklishin:masterfrom
michaelklishin merged 8 commits intomichaelklishin:masterfrom
Conversation
michaelklishin
requested changes
Nov 29, 2021
Contributor
Author
|
All the tests are passing, can you merge the changes @michaelklishin |
Contributor
Author
|
also can we use a docker container, instead of installing rabbitmq-server on a debian OS? |
Owner
|
Containers make sense for Actions. I don't want to switch to container-based nodes only for local development but would consider a PR that adds support for containers as an option locally, similarly to how Bunny does it. |
Contributor
Author
|
This current PR adds support to use containers locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.