Add tests for invalid and edge cases in DurationValidator#7287
Merged
shakuzen merged 1 commit intomicrometer-metrics:1.15.xfrom Mar 13, 2026
Merged
Conversation
DurationValidator validates externally supplied duration configuration values. Existing tests cover only successful parsing scenarios. This change adds tests for several invalid and boundary inputs: - blank values - malformed duration strings - missing units - invalid units - invalid ISO8601 durations - null values These tests improve coverage of validation paths and help prevent regressions in configuration parsing. Signed-off-by: Joowon-Seo <[email protected]>
Joowon-Seo
force-pushed
the
add-duration-validator-tests-115x
branch
from
1e8614b to
dd99b85
Compare
shakuzen
approved these changes
Mar 13, 2026
shakuzen
added
type: task
etrandafir93
pushed a commit
to etrandafir93/micrometer
that referenced
this pull request
Mar 21, 2026
…-metrics#7287) DurationValidator validates externally supplied duration configuration values. Existing tests cover only successful parsing scenarios. This change adds tests for several invalid and boundary inputs: - blank values - malformed duration strings - missing units - invalid units - invalid ISO8601 durations - null values These tests improve coverage of validation paths and help prevent regressions in configuration parsing. Signed-off-by: Joowon-Seo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DurationValidator validates externally supplied duration configuration values. Existing tests cover only successful parsing scenarios.
This change adds tests for several invalid and boundary inputs:
These tests improve coverage of validation paths and help prevent regressions in configuration parsing.
This PR supersedes #7286 and rebases the change on top of the 1.15.x branch as requested.