Refresh check-spelling 0.0.26 by jsoref · Pull Request #47119 · microsoft/PowerToys

jsoref · 2026-04-20T16:18:29Z

Summary of the Pull Request

This is roughly a refresh based on https://github.com/check-spelling/spell-check-this/tree/976261d7b7184b67231c8668f2b35438496ca44f

There are a couple of interesting new rules and I've extended one of the patterns to all letters. I'll call things out...

PR Checklist

Closes: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

https://github.com/jsoref/PowerToys/actions/runs/24677466687

jsoref · 2026-04-20T16:19:13Z

-# D2D
-#D?2D
-


Since this pattern is commented out and since I don't seem to have it in my baseline, I've dropped it.

jsoref · 2026-04-20T16:20:03Z

 # Non-English
 # Even repositories expecting pure English content can unintentionally have Non-English content... People will occasionally mistakenly enter [homoglyphs](https://en.wikipedia.org/wiki/Homoglyph) which are essentially typos, and using this pattern will mean check-spelling will not complain about them.
-#
+# .
 # If the content to be checked should be written in English and the only Non-English items will be people's names, then you can consider adding this.
-#
+# .
 # Alternatively, if you're using check-spelling v0.0.25+, and you would like to _check_ the Non-English content for spelling errors, you can. For information on how to do so, see:
 # https://docs.check-spelling.dev/Feature:-Configurable-word-characters.html#unicode


These .s ensure that the comment for the hint starts from Non-English if the pattern catches.

jsoref · 2026-04-20T16:22:20Z

+# Generally words are written with `'s`, not `"s`
+[^=|+']\s\w+"s\s
+
+# Don't miswrite **irreversible binomials**


This is a new fancy rule, and it snagged at least one thing.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

DHowett

I love this, and I can already see the places in Windows Terminal where we've made similar errors. Push new updates at will - I'll reapprove

DHowett · 2026-04-23T21:52:44Z

+# Generally words are written with `'s`, not `"s`
+[^=|+']\s\w+"s\s
+
+# Don't miswrite **irreversible binomials**


I LOVE THIS, OMG

DHowett · 2026-04-23T21:52:54Z

+# It's possible this is some strange CSV dialect, but, even so, you could probably move the space.
+\s[A-Za-z]{3,} ,[A-Za-z]{3,}\s
+
+# Should be `could`/`should`/`would`+`'ve`


thank you. we're so bad about this.

DHowett · 2026-04-23T21:55:01Z

 # Alt text should be short
 \balt=(?:'[^']{126,}'|"[^"]{126,}")

+# Should be either of `default` or `fallback`, but not both


I suppose that in a narrow use case (in e.g. a settings system) we might have a fallback option and the user can configure what the fallback is, and then we would have a default fallback.

You can always write a specific pattern for it or comment it out.

I might eventually rewrite the advice for this, since you're right, there are some exceptional cases. But, that's true for all patterns.

I think on average, the advice is right, sadly when it triggers, about half the time I don't have the energy to suggest a correction, so I just ignore it/comment it out.

DHowett · 2026-04-23T22:04:51Z

/azp run

azure-pipelines · 2026-04-23T22:05:02Z

Azure Pipelines successfully started running 1 pipeline(s).

jsoref · 2026-04-23T22:20:00Z

 # Alt text should be short
 \balt=(?:'[^']{126,}'|"[^"]{126,}")

+# Should be either of `default` or `fallback`, but not both


You can always write a specific pattern for it or comment it out.

I might eventually rewrite the advice for this, since you're right, there are some exceptional cases. But, that's true for all patterns.

I think on average, the advice is right, sadly when it triggers, about half the time I don't have the energy to suggest a correction, so I just ignore it/comment it out.

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Dustin L. Howett <dustin@howett.net>

DHowett

Thanks so much

DHowett · 2026-04-23T22:38:00Z

/azp run

azure-pipelines · 2026-04-23T22:38:10Z

Azure Pipelines successfully started running 1 pipeline(s).

## Problem Since #47119 (`Refresh check-spelling 0.0.26`, merged 2026-04-23) refreshed the check-spelling tooling and rewrote `.github/actions/spell-check/expect.txt` (938 lines / 633 deletions), the check-spelling bot has been leaving a noisy advisory comment on **every PR**: > #### These words are not needed and should be removed > ABlocked AClient AColumn ACR ADate ADifferent AHybrid ALarger AModifier ANull AOklab APeriod ARandom ARemapped ASingle ASUS bck … The same ~150-word list is appended verbatim to every PR the bot looks at (verified against #48058, #48102, #48104 — the list is identical). These tokens are residual orphans in `expect.txt` from before the 0.0.26 refresh and no longer match anything in source. ## Fix Removes exactly the 147 orphan tokens that the bot has consistently flagged as `now absent` from `.github/actions/spell-check/expect.txt`. The removed tokens are exclusively the ones the bot itself identified. All uppercase Win32 / DirectWrite identifiers that are still used in source (`DWRITE`, `LWIN`, `VCENTER`, `VREDRAW`, etc.) are **preserved**. ## Verification - Diff is a single file, deletions only: `expect.txt` shrinks from 2343 → 2196 lines. - Each of the 4 uppercase Win32 tokens (`DWRITE` line 514, `LWIN` 1074, `VCENTER` 2105, `VREDRAW` 2144 in the original) remains in the file. - The check-spelling job on this PR should now post a clean report (no `should be removed` block). ## Background — which PR introduced the drift | PR | Date | What it changed | |----|------|-----------------| | **#47119** | 2026-04-23 | Refreshed check-spelling to 0.0.26; rewrote `expect.txt` with 938 line-changes (633 deletions, 305 additions). The duplicated lowercase/uppercase entries and many obsolete tokens originate here. | --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <Copilot@users.noreply.github.com>

jsoref requested a review from a team as a code owner April 20, 2026 16:18

jsoref commented Apr 20, 2026

View reviewed changes

jsoref added 15 commits April 20, 2026 12:32

spelling: an

39d27fa

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: be

69ca009

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: black or white

3279285

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: exist

df2abf2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: its

88082a6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: lowercase

31f90d3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: means

3d37360

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: more or less

6c1884a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: or

4cf4e61

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: read and write

87338c6

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: three

5800e5d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: to

c7a9a2b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: uppercase

231eb4a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: whether or not

2994afd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

Upgrade check-spelling to v0.0.26

4ecd4c3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the refresh-check-spelling-0.0.26 branch from aa60161 to 4ecd4c3 Compare April 20, 2026 16:33

DHowett approved these changes Apr 23, 2026

View reviewed changes

jsoref commented Apr 23, 2026

View reviewed changes

Apply suggestions from code review

177a07f

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Dustin L. Howett <dustin@howett.net>

DHowett approved these changes Apr 23, 2026

View reviewed changes

DHowett merged commit 2e5c7d2 into microsoft:main Apr 24, 2026
11 checks passed

jsoref deleted the refresh-check-spelling-0.0.26 branch April 24, 2026 02:34

LegendaryBlair added 0.99 Area-Build Issues pertaining to the build system, CI, infrastructure, meta labels Apr 24, 2026

LegendaryBlair added this to the PowerToys 0.99 milestone Apr 24, 2026

LegendaryBlair mentioned this pull request May 25, 2026

[CI] Prune orphan tokens from check-spelling expect.txt #48110

Merged

		# D2D
		#D?2D

Conversation

jsoref commented Apr 20, 2026

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DHowett left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DHowett commented Apr 23, 2026

Uh oh!

azure-pipelines Bot commented Apr 23, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DHowett left a comment

Choose a reason for hiding this comment

Uh oh!

DHowett commented Apr 23, 2026

Uh oh!

azure-pipelines Bot commented Apr 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants