Fix ZoomIt Record hotkey ignoring Alt modifier when Alt is the only modifier key

[Copilot]

Summary of the Pull Request

ZoomIt derives three recording hotkeys from one base key via XOR: fullscreen (base), crop (base XOR Shift), window (base XOR Alt). When Alt is the sole modifier, base XOR Alt = 0, registering a modifier-less hotkey that captures every bare keypress (e.g., pressing 5 triggers window recording).

Zoomit.cpp — 4 hotkey registration sites:

• Guard RECORD_CROP_HOTKEY registration behind (g_RecordToggleMod ^ MOD_SHIFT) != 0
• Guard RECORD_WINDOW_HOTKEY registration behind (g_RecordToggleMod ^ MOD_ALT) != 0

// Before (all 4 sites):
registerHotkey( RECORD_CROP_HOTKEY, ( g_RecordToggleMod ^ MOD_SHIFT ) | MOD_NOREPEAT, ... );
registerHotkey( RECORD_WINDOW_HOTKEY, ( g_RecordToggleMod ^ MOD_ALT ) | MOD_NOREPEAT, ... );

// After:
if ( g_RecordToggleMod ^ MOD_SHIFT ) {
    registerHotkey( RECORD_CROP_HOTKEY, ( g_RecordToggleMod ^ MOD_SHIFT ) | MOD_NOREPEAT, ... );
}
if ( g_RecordToggleMod ^ MOD_ALT ) {
    registerHotkey( RECORD_WINDOW_HOTKEY, ( g_RecordToggleMod ^ MOD_ALT ) | MOD_NOREPEAT, ... );
}

ZoomItViewModel.cs — RecordToggleKeyCrop / RecordToggleKeyWindow computed properties:

• Return null when the derived hotkey would have no modifier keys, so the Settings UI omits the inapplicable shortcut description rather than displaying a bare-key shortcut.

PR Checklist

• Closes: #xxx
• Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end-user-facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

ZoomIt registers crop and window recording variants by XOR-ing the base modifier with MOD_SHIFT and MOD_ALT respectively. This design breaks when the base modifier equals the XOR target — the result is 0, and RegisterHotKey with no modifiers intercepts every bare keypress of that key system-wide.

The fix is symmetric across all 4 registration sites (standalone registerHotkey() in RegisterAllHotkeys, the legacy dialog OK path, and two WM_CREATE-adjacent paths): skip the derived hotkey registration when the computed modifier is zero. The Settings UI ViewModel mirrors this logic by returning null for the affected computed properties, causing the converter to emit an empty string instead of a modifier-less shortcut label.

Validation Steps Performed

• Code review confirmed fix is applied consistently across all 4 RegisterHotKey call sites in Zoomit.cpp
• Verified HotkeySettingsToLocalizedStringConverter returns string.Empty for null input — no display regression in Settings UI
• Confirmed the default Ctrl+5 hotkey is unaffected (MOD_CONTROL ^ MOD_ALT = MOD_CONTROL | MOD_ALT ≠ 0)

[Copilot]

Pull request overview

Fixes a ZoomIt recording hotkey edge case where deriving crop/window recording hotkeys via XOR can produce a modifier-less hotkey (when Alt or Shift is the only modifier), causing bare keypresses to trigger recording. The PR updates both the native ZoomIt hotkey registration and the Settings UI display logic to avoid advertising/creating these unsafe derived shortcuts.

Changes:

• Skip registering derived crop/window record hotkeys when the XOR-derived modifier mask is 0 (preventing key-only global hotkeys).
• Update Settings UI computed properties to return null for inapplicable derived shortcuts so the UI omits the label instead of showing a bare-key shortcut.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File	Description
src/settings-ui/Settings.UI/ViewModels/ZoomItViewModel.cs	Suppresses display of derived record shortcuts when XOR would produce a modifier-less hotkey.
src/modules/ZoomIt/ZoomIt/Zoomit.cpp	Prevents registration of derived record hotkeys when the XOR-derived modifier would be zero.