CmdPal: fix initializing the Run history in AOT builds#48463
CmdPal: fix initializing the Run history in AOT builds#48463zadjii-msft wants to merge 1 commit into
Conversation
Regressed in one of the last two commits. The problem was that `history.ToImmutableList()` ran on the projected `IVector<string>`. `ImmutableList.CreateRange` checks for `IReadOnlyCollection<string>`, and resolving that interface on a WinRT object requires a helper type that AOT can't generate. So we have to just _not do that_. Closes #48445
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, 👼 SARIF report, or 📝 job summary for details.
See ❌ Event descriptions for more information. These words are not needed and should be removedDWRITE LWIN nonstd VCENTER VREDRAWForbidden patterns 🙅 (1)In order to address this, you could change the content to not match the forbidden patterns (comments before forbidden patterns may help explain why they're forbidden), add patterns for acceptable instances, or adjust the forbidden patterns themselves. These forbidden patterns matched content: In English, duplicated words are generally mistakesThere are a few exceptions (e.g. "that that").
If the flagged items are 🤯 false positivesIf items relate to a ...
|
Regressed in one of the last two releases.
The problem was that
history.ToImmutableList()ran on the projectedIVector<string>.ImmutableList.CreateRangechecks forIReadOnlyCollection<string>, and resolving that interface on a WinRT object requires a helper type that AOT can't generate.So we have to just not do that.
Closes #48445