Fix Euro symbol priority on Quick Accent for German and Spanish (#48488)#48489
Open
maescoder wants to merge 1 commit into
Open
Fix Euro symbol priority on Quick Accent for German and Spanish (#48488)#48489maescoder wants to merge 1 commit into
maescoder wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Euro symbol appearing as default on Quick Accent
VK_Ekey for Spanish and German layouts, restoring pre-v0.100.0 behavior.Summary of the Pull Request
This PR removes the standalone
€symbol from theLanguage.DE(German) character mappings and the["é", "€"]mapping fromLanguage.SP(Spanish) for theVK_Ekey inCharacterMappings.cs.Because Quick Accent aggregates language arrays alphabetically, the German
["€"]array was being aggregated before the Spanish array. This inadvertently caused the€symbol to take priority and become the default character for users mixing Spanish and German, overriding the desiredécharacter. Users who wish to access the Euro symbol globally can still do so by enabling theCurrencylanguage group.PR Checklist
Detailed Description of the Pull Request / Additional comments
Before version 0.100.0, pressing
ewith Spanish and German selected would correctly default toé. The addition of the Euro symbol to specific languages introduced an alphabetical aggregation bug, floating the€to the front of the list for multi-language users. Removing it from these specific Language sets resolves the issue and aligns with the purpose of the distinctCurrency(CUR) group.Validation Steps Performed
CharacterMappings.csthat removing the[LetterKey.VK_E] = ["€"]line fromLanguage.DEand revertingLanguage.SP'sVK_Eback to["é"]ensures thatéis restored as the first and primary accent for theekey.