Skip to content

Fix Euro symbol priority on Quick Accent for German and Spanish (#48488)#48489

Open
maescoder wants to merge 1 commit into
microsoft:mainfrom
maescoder:main
Open

Fix Euro symbol priority on Quick Accent for German and Spanish (#48488)#48489
maescoder wants to merge 1 commit into
microsoft:mainfrom
maescoder:main

Conversation

@maescoder

@maescoder maescoder commented Jun 11, 2026

Copy link
Copy Markdown

Fixes Euro symbol appearing as default on Quick Accent VK_E key for Spanish and German layouts, restoring pre-v0.100.0 behavior.

Summary of the Pull Request

This PR removes the standalone symbol from the Language.DE (German) character mappings and the ["é", "€"] mapping from Language.SP (Spanish) for the VK_E key in CharacterMappings.cs.

Because Quick Accent aggregates language arrays alphabetically, the German ["€"] array was being aggregated before the Spanish array. This inadvertently caused the symbol to take priority and become the default character for users mixing Spanish and German, overriding the desired é character. Users who wish to access the Euro symbol globally can still do so by enabling the Currency language group.

PR Checklist

  • Communication: I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end-user-facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Before version 0.100.0, pressing e with Spanish and German selected would correctly default to é. The addition of the Euro symbol to specific languages introduced an alphabetical aggregation bug, floating the to the front of the list for multi-language users. Removing it from these specific Language sets resolves the issue and aligns with the purpose of the distinct Currency (CUR) group.

Validation Steps Performed

  • Manual Validation: Verified in CharacterMappings.cs that removing the [LetterKey.VK_E] = ["€"] line from Language.DE and reverting Language.SP's VK_E back to ["é"] ensures that é is restored as the first and primary accent for the e key.

@niels9001 niels9001 requested a review from daverayment June 11, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Euro symbol appears on Quick Accent after the update 100

1 participant