Fix check-spelling: exclude ZoomIt rnnoise third-party tree and dedupe excludes#48548
Open
yeelam-gordon wants to merge 1 commit into
Open
Fix check-spelling: exclude ZoomIt rnnoise third-party tree and dedupe excludes#48548yeelam-gordon wants to merge 1 commit into
yeelam-gordon wants to merge 1 commit into
Conversation
The check-spelling workflow has been failing on PRs because of newly added third-party ZoomIt audio/video assets and pre-existing duplicate entries in the excludes file: * forbidden-pattern: src/modules/ZoomIt/ZoomIt/rnnoise/kiss_fft.h:79 contains "an fft" - kiss_fft is third-party; exclude the whole rnnoise/ tree. * large-file (~30MB) on src/modules/ZoomIt/ZoomIt/rnnoise/ rnnoise_data_little.c - covered by the same rnnoise/ exclusion. * binary-file on src/modules/ZoomIt/ZoomIt/selfie_segmentation.onnx - add explicit exclusion. * duplicate-pattern x2: FuzzyMatcherComparisonTests.cs and FuzzyMatcherDiacriticsTests.cs were each listed twice (lines 108/115 and 109/116). Drop the duplicates. Net change: -2 duplicates, +2 new ZoomIt third-party exclusions (file count unchanged at 148). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
crutkas
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Check Spellingworkflow has been failing on PRs againstmain(e.g. #48546) due to issues introduced by the recent ZoomIt webcam-blur / noise-cancellation change (#48266) plus two pre-existing duplicate entries in.github/actions/spell-check/excludes.txt.What the bot reported
forbidden-pattern(Should bea)src/modules/ZoomIt/ZoomIt/rnnoise/kiss_fft.h:79— third-party kiss_fft header containsan fftlarge-file(~30 MB)src/modules/ZoomIt/ZoomIt/rnnoise/rnnoise_data_little.cbinary-filesrc/modules/ZoomIt/ZoomIt/selfie_segmentation.onnxduplicate-pattern×2excludes.txtlines 115/116 duplicate lines 108/109 (FuzzyMatcher{Comparison,Diacritics}Tests.cs)Fix
.github/actions/spell-check/excludes.txt:FuzzyMatcher*Tests.cslines.^src/modules/ZoomIt/ZoomIt/rnnoise/— entire third-party rnnoise/kiss_fft tree (covers both thean fftforbidden-pattern inkiss_fft.hand the 30 MBrnnoise_data_little.clarge-file).^src/modules/ZoomIt/ZoomIt/selfie_segmentation\.onnx$— the ML model binary.Net change:
-2duplicates,+2new exclusions → file count unchanged at 148 lines.Notes
rnnoise/should not be spell-checked; this matches how other vendored/third-party trees in the repo are handled (e.g.src/common/CalculatorEngineCommon/exprtk.hpp,src/common/sysinternals/Eula/).Check Spellingonmain.