Rename FileReader.readAsText second parameter from 'label' to 'encoding'#26874
Closed
chozzz wants to merge 1 commit intomicrosoft:masterfrom
Closed
Rename FileReader.readAsText second parameter from 'label' to 'encoding'#26874chozzz wants to merge 1 commit intomicrosoft:masterfrom
chozzz wants to merge 1 commit intomicrosoft:masterfrom
Conversation
RyanCavanaugh
requested changes
Sep 17, 2018
Member
RyanCavanaugh
left a comment
RyanCavanaugh
left a comment
There was a problem hiding this comment.
Changes should be made in src/lib, not lib/
chozzz
force-pushed
the
fix-filereader-readastext-second-parameter-naming
branch
from
3dab79b to
c00df4c
Compare
Contributor
Author
|
@RyanCavanaugh My bad 8( - Fixed in the latest commit. |
|
This PR is open to fix this issue: microsoft/TypeScript-DOM-lib-generator#536 Note that I had also attempted to make this change in this repo but was directed to make the change in TSJS-lib-generator: #25798 Unfortunately the PR is still stuck in review after 3 months. Even getting the W3C to change the parameter name used in the standard was a lot faster. |
Member
|
Fixed in linked repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25797
Note that files in
lib/[dom|webworker].generated.tsare not modified.