Port over changes to the ScriptSnapshot API from the languageService-v2 branch.#444
Merged
CyrusNajmabadi merged 2 commits intomasterfrom Aug 13, 2014
Merged
Port over changes to the ScriptSnapshot API from the languageService-v2 branch.#444CyrusNajmabadi merged 2 commits intomasterfrom
CyrusNajmabadi merged 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
I would make that options.
the batch compiler users do not care about version, LS users do, also version is not used in the batch compilation scenarios and all the LS entry points sets that; so you are probably fine with setting the version to undefined in batch.
Contributor
Author
There was a problem hiding this comment.
The problem with making things optional is that people forget to pass the right value in. When i had it optional there were a bunch of places that were missed, thus causing the version of the source file to be wrong.
Contributor
|
LGTM, the only thing that is sticking is the version parameter in the constructor for soruceFile |
Conflicts: src/services/services.ts
CyrusNajmabadi
added a commit
that referenced
this pull request
Aug 13, 2014
Port over changes to the ScriptSnapshot API from the languageService-v2 branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port over changes to the ScriptSnapshot API from the languageService-v2 branch.