Use replaceAll instead of an incorrect RegExp for tsserver log sanitization.#54454
Merged
DanielRosenwasser merged 1 commit intomainfrom May 30, 2023
Merged
Use replaceAll instead of an incorrect RegExp for tsserver log sanitization.#54454DanielRosenwasser merged 1 commit intomainfrom
replaceAll instead of an incorrect RegExp for tsserver log sanitization.#54454DanielRosenwasser merged 1 commit intomainfrom
Conversation
typescript-bot
added
Author: Team
For Uncommitted Bug
andrewbranch
approved these changes
May 30, 2023
Member
Author
|
@typescript-bot cherry-pick this to release-5.1 |
Collaborator
|
Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into |
Collaborator
|
Hey @DanielRosenwasser, I've opened #54456 for you. |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
May 30, 2023
Component commits: 2a9c204 Use `replaceAll` instead of an incorrect `RegExp` for tsserver log sanitization.
DanielRosenwasser
added a commit
that referenced
this pull request
May 30, 2023
…e-5.1 (#54456) Co-authored-by: Daniel Rosenwasser <DanielRosenwasser@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we use the TypeScript version as a raw input string for a
RegExpand run it over TSServer logs. But that means that when you switch the version to5.1.2a whole bunch of random strings with5and1and2in them are replaced withFakeVersionbecause we're really running/5.1.2/gover the logs (which is5{AnyCharacter}1{AnyCharacter}2).So this PR avoids constructing the incorrect
RegExpby using areplaceAllfunction which uses the newer built-in if it's available.