Skip to content

Fix circular promise references #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwasplund-msft wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix circular promise references #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f7c170
Fix circular promise references
mwasplund-msft Feb 18, 2026
baa253f
Change files
mwasplund-msft Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions change/change-e750e299-3f52-4757-8968-fb45d7ecf356.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"type": "patch",
"comment": "Fix circular promise in fetchTokens",
"packageName": "@microsoft/yarn-plugin-ado-auth",
"email": "[email protected]",
"dependentChangeType": "patch"
}
]
}
9 changes: 6 additions & 3 deletions packages/yarn-plugin-ado-auth/src/tokenCache.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ export class TokenCache {
*/
private async fetchToken(registry: string, ident?: Ident): Promise<string> {
const configuration = this.configuration;
let token: string | null = null;

await StreamReport.start(
{ configuration, stdout: process.stdout },
async (report) => {
Expand All @@ -70,6 +72,7 @@ export class TokenCache {
const authConfig = this.getAuthConfiguration(registry, ident);
const tokenFromYarnrc = getConfigString(authConfig, "npmAuthToken");
if (tokenFromYarnrc) {
token = tokenFromYarnrc;
this.cache[registry] = tokenFromYarnrc;
report.reportInfo(
null,
Expand All @@ -91,6 +94,7 @@ export class TokenCache {
false,
this.azureAuthPath,
);
token = pat;
this.cache[registry] = pat;
report.reportInfo(
null,
Expand All @@ -99,11 +103,10 @@ export class TokenCache {
},
);

const pat = this.cache[registry];
if (pat == null) {
if (token == null) {
throw new Error(`Failed to authenticate to: ${registry}`);
}
return pat;
return token;
}

/**
Expand Down
⚡