Fix ptest issue for gd.#16901
Open
AkarshHCL wants to merge 3 commits into
Open
Conversation
Author
|
Buddy Build is successful. |
Kanishk-Bansal
requested changes
May 7, 2026
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
LIBRARY_PATH is a compile-time linker variable; it is unnecessary at test run time because %check does not invoke the compiler. Recommend dropping the export LIBRARY_PATH=... line
TESTS_ENVIRONMENT="LD_LIBRARY_PATH=..." is partly redundant with the export LD_LIBRARY_PATH=... immediately above. The autotools test harness already inherits the exported environment, so TESTS_ENVIRONMENT adds nothing here unless the test runner explicitly wipes the env.
Author
|
Removed the compile-time linker variable . |
Kanishk-Bansal
approved these changes
Jun 15, 2026
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
added an unescaped fix in changelog
0f11983 to
f6f9170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Configured test environment (LD_LIBRARY_PATH, LIBRARY_PATH, TESTS_ENVIRONMENT) to use locally built libraries and marked failing TIFF tests as XFAIL due to known upstream libtiff incompatibility.
Reference to the known issue-libgd/libgd#900
Change Log
Does this affect the toolchain?
NO
Test Methodology