Skip to content

Fix ptest issue for gd.#16901

Open
AkarshHCL wants to merge 3 commits into
microsoft:3.0-devfrom
AkarshHCL:topic-ptest_gd
Open

Fix ptest issue for gd.#16901
AkarshHCL wants to merge 3 commits into
microsoft:3.0-devfrom
AkarshHCL:topic-ptest_gd

Conversation

@AkarshHCL

@AkarshHCL AkarshHCL commented Apr 27, 2026

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

Configured test environment (LD_LIBRARY_PATH, LIBRARY_PATH, TESTS_ENVIRONMENT) to use locally built libraries and marked failing TIFF tests as XFAIL due to known upstream libtiff incompatibility.

Reference to the known issue-libgd/libgd#900

Change Log
  • SPECS/gd/gd.spec
Does this affect the toolchain?

NO

Test Methodology
  • Screenshot of successful build-
image

@AkarshHCL AkarshHCL requested a review from a team as a code owner April 27, 2026 08:26
@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Apr 27, 2026
@AkarshHCL AkarshHCL marked this pull request as draft April 27, 2026 08:27
@AkarshHCL AkarshHCL marked this pull request as ready for review April 27, 2026 09:35
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label Apr 28, 2026
@Kanishk-Bansal

Copy link
Copy Markdown

BUILD

@AkarshHCL

Copy link
Copy Markdown
Author

Buddy Build is successful.

@Kanishk-Bansal Kanishk-Bansal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIBRARY_PATH is a compile-time linker variable; it is unnecessary at test run time because %check does not invoke the compiler. Recommend dropping the export LIBRARY_PATH=... line

TESTS_ENVIRONMENT="LD_LIBRARY_PATH=..." is partly redundant with the export LD_LIBRARY_PATH=... immediately above. The autotools test harness already inherits the exported environment, so TESTS_ENVIRONMENT adds nothing here unless the test runner explicitly wipes the env.

@AkarshHCL

Copy link
Copy Markdown
Author

Removed the compile-time linker variable .

@AkarshHCL AkarshHCL requested a review from Kanishk-Bansal May 12, 2026 10:01
@kgodara912

Copy link
Copy Markdown

Buddy build

Comment thread SPECS/gd/gd.spec Outdated

@Kanishk-Bansal Kanishk-Bansal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added an unescaped fix in changelog

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec) ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants