Skip to content

[Work Item #17159 & #17194] fix ptest for python-omegaconf#17332

Merged
kgodara912 merged 2 commits into
microsoft:3.0-devfrom
Kanishk-Bansal:topic/python-omegaconf/ptest
Jun 14, 2026
Merged

[Work Item #17159 & #17194] fix ptest for python-omegaconf#17332
kgodara912 merged 2 commits into
microsoft:3.0-devfrom
Kanishk-Bansal:topic/python-omegaconf/ptest

Conversation

@akhila-guruju

@akhila-guruju akhila-guruju commented May 18, 2026

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Add and fix ptest for python-omegaconf

Upstream Patch reference: https://github.com/omry/omegaconf/commit/a656e85e44795d471c812d9f9c326967465cf788.patch
PR: omry/omegaconf#1225

Modified to apply to Azure Linux.
Only first 2 commit changes are relevant to the ptests.
Replace deprecated pkg_resources with pkgutil and fix failing test for Python 3.12+
Combined commit changes: https://github.com/omry/omegaconf/pull/1225/changes/BASE..8cb50f64ea58c217f908d3f65cb09c0707633234
The change made in pyproject.toml is already present in v2.3.0

No minor version upgrade can fix ptest failures.
disabled pip version check in %check section to fix the error caused during build.

Change Log
  • modified: SPECS/python-omegaconf/python-omegaconf.spec
  • new file: SPECS/python-omegaconf/upstream-fix-for-ptests.patch
Does this affect the toolchain?

NO

Associated issues
Links to CVEs
Test Methodology
  • Local Build
  • Patch applies cleanly
image image

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels May 18, 2026
@akhila-guruju akhila-guruju changed the title fix ptest for python-omegaconf [Work Item #17159] fix ptest for python-omegaconf May 18, 2026
@akhila-guruju akhila-guruju changed the title [Work Item #17159] fix ptest for python-omegaconf [Work Item #17159 & #17194] fix ptest for python-omegaconf May 18, 2026
@akhila-guruju

Copy link
Copy Markdown
Author

Buddy Build has passed.

@akhila-guruju akhila-guruju marked this pull request as ready for review May 18, 2026 10:53
@akhila-guruju akhila-guruju requested a review from a team as a code owner May 18, 2026 10:53
@Kanishk-Bansal Kanishk-Bansal added the ptest package testing (%check section in spec) label May 18, 2026
@akhila-guruju akhila-guruju force-pushed the topic/python-omegaconf/ptest branch from 128dd1b to 89db1c3 Compare June 3, 2026 04:30
@akhila-guruju

Copy link
Copy Markdown
Author

Buddy Build after rebase has passed.

@suresh-thelkar suresh-thelkar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Can you also attach ptest logs please?

@akhila-guruju

akhila-guruju commented Jun 4, 2026

Copy link
Copy Markdown
Author

@suresh-thelkar

Copy link
Copy Markdown

Code changes look good to me. Can you also attach ptest logs please?

We are good to go from my side, once you attach the ptest logs as discussed.

@akhila-guruju

Copy link
Copy Markdown
Author

Code changes look good to me. Can you also attach ptest logs please?

We are good to go from my side, once you attach the ptest logs as discussed.

Updated Successful ptest logs in the above comment.

@suresh-thelkar suresh-thelkar added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jun 5, 2026

@kgodara912 kgodara912 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No source upgrade, just fixing the test suite to actually run and pass on Python 3.12+ with patch taken from upstream. Buddy build is successful. LGTM.

@kgodara912 kgodara912 merged commit 5b75326 into microsoft:3.0-dev Jun 14, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec) ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants