[Work Item #17159 & #17194] fix ptest for python-omegaconf#17332
Conversation
ptest for python-omegaconf
ptest for python-omegaconfptest for python-omegaconf
|
Buddy Build has passed. |
128dd1b to
89db1c3
Compare
|
Buddy Build after rebase has passed. |
suresh-thelkar
left a comment
There was a problem hiding this comment.
Code changes look good to me. Can you also attach ptest logs please?
|
ptest was resolved through a series of changes. Attaching all the failed ptest logs up to the point of success. Local ptest error logs while fixing: Success ptest logs: python-omegaconf-2.3.0-2.azl3.src.rpm.test.log
|
We are good to go from my side, once you attach the ptest logs as discussed. |
Updated Successful ptest logs in the above comment. |
kgodara912
left a comment
There was a problem hiding this comment.
No source upgrade, just fixing the test suite to actually run and pass on Python 3.12+ with patch taken from upstream. Buddy build is successful. LGTM.

Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Add and fix ptest for python-omegaconf
Upstream Patch reference: https://github.com/omry/omegaconf/commit/a656e85e44795d471c812d9f9c326967465cf788.patch
PR: omry/omegaconf#1225
Modified to apply to Azure Linux.
Only first 2 commit changes are relevant to the ptests.
Replace deprecated pkg_resources with pkgutil and fix failing test for Python 3.12+
Combined commit changes: https://github.com/omry/omegaconf/pull/1225/changes/BASE..8cb50f64ea58c217f908d3f65cb09c0707633234
The change made in
pyproject.tomlis already present in v2.3.0No minor version upgrade can fix ptest failures.
disabled pip version check in %check section to fix the error caused during build.
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology