fix(vm-iso-installer): include rootfiles in target install#17720
Open
kgodara912 wants to merge 1 commit into
Open
fix(vm-iso-installer): include rootfiles in target install#17720kgodara912 wants to merge 1 commit into
kgodara912 wants to merge 1 commit into
Conversation
rootfiles ships the default skeleton dotfiles for root's home
directory (.bashrc, .bash_profile, .bash_logout, .cshrc, .tcshrc).
Without it the installed system has an empty /root, which causes
`sudo su` (and similar login shells) to prompt:
Couldn't find a personal initialization file.
Use a generic skeleton file? [Y/n]
Add it to INSTALL_PKGS so it lands in both the kickstart %packages
section and the offline repo.
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures the vm-iso-installer target installation includes the rootfiles package so /root gets the default skeleton dotfiles (e.g., .bashrc, .bash_profile), improving the root login shell experience after install (e.g., via sudo su).
Changes:
- Add
rootfilesto the installer’sINSTALL_PKGSlist so it is included in both the kickstart%packagessection and the generated offline repo contents.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rootfilesships the default skeleton dotfiles for root's home directory (.bashrc, .bash_profile, .bash_logout, .cshrc, .tcshrc). Without it, the installed system has an empty /root, which causessudo su(and similar login shells) to not show the root@.. for normal user sudo su.Add it to INSTALL_PKGS so it lands in both the kickstart %packages section and the offline repo.