Fixed CVE-2023-44487 in nginx and golang (CP of #6381)#6395
Merged
Conversation
Co-authored-by: Dan Streetman <ddstreet@ieee.org> Co-authored-by: Pawel Winogrodzki <pawelwi@microsoft.com>
nicogbg
approved these changes
Oct 12, 2023
christopherco
approved these changes
Oct 12, 2023
rikenm1
approved these changes
Oct 12, 2023
rikenm1
left a comment
rikenm1
left a comment
There was a problem hiding this comment.
Approved with some comments. Can you address the comments?
|
|
||
| %changelog | ||
| * Wed Oct 04 2023 Minghe Ren <mingheren@microsoft.com> - 1.18.0-19 | ||
| * Wed Oct 11 2023 Minghe Ren <mingheren@microsoft.com> - 1.18.0-20 |
There was a problem hiding this comment.
are we allowed to change the dates from the changelog?
| # rhcontainerbot account currently managed by lsm5 | ||
| %changelog | ||
| * Wed Oct 04 2023 Minghe Ren <mingheren@microsoft.com> - 4.1.1-16 | ||
| * Wed Oct 11 2023 Minghe Ren <mingheren@microsoft.com> - 4.1.1-17 |
There was a problem hiding this comment.
same comment. was the change not released before this swap?
dmcilvaney
approved these changes
Oct 12, 2023
hbeberman
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Cherry-pick of #6381 from the
fasttrack/2.0branch. Fast-track branch changes take priority over the ones in the dev branches, thus some re-dating of entries in the changelogs.Change Log
Does this affect the toolchain?
Yes.
Associated issues
Links to CVEs
Test Methodology