Skip publishing packages that aren't bumped#1126
Merged
ecraig12345 merged 3 commits intomainfrom Dec 20, 2025
Merged
Conversation
ecraig12345
force-pushed
the
ecraig/packages-publish-fix
branch
from
ebd9f6c to
3cf4910
Compare
ecraig12345
force-pushed
the
ecraig/packages-publish-fix
branch
from
3cf4910 to
a12984f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons described in #1123, it's possible that a package could end up in the
modifiedPackageslist even if it's not being bumped (withbumpDeps: falseorscope). This would probably cause publishing to fail whenvalidatePackageVersionsis called since that version would already exist in the registry.This PR updates
getPackagesToPublishto skip packages that aren't new but have nocalculatedChangeTypesentry (so their version isn't actually being bumped). I also updated the args ofgetPackagesToPublishto be more explicit about their behavior, and added tests.Other changes are just semi-related comment and test improvements, including more realistic publishing tests.
(Working on this change brought up some questions about nuances of
bump=false/--no-bumpwhich are documented in #1125 and would require more thought to fix.)