sync: fix precedence of tag options#557
Merged
ecraig12345 merged 1 commit intomainfrom Nov 19, 2025
Merged
Conversation
kenotron
approved these changes
Jul 20, 2021
ecraig12345
force-pushed
the
ecraig/fix-sync-2
branch
from
3582115 to
f0fbced
Compare
ecraig12345
force-pushed
the
ecraig/fix-sync-2
branch
from
f0fbced to
07f8f85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We discovered in Fluent UI that the
synccommand was not respecting per-packagetagoptions. Fix is in the helper function which fetches the versions, each package info'scombinedOptionsalready contains thetagoption with the appropriate order of precedence, so use that instead of overriding with the global option.(Note: CLI
--tagoption overrides ALL other options, including per-packagetag.)Also make the tests use more realistic beachball options merging.