feat: initial work to update the fast-components design system#3135
Merged
chrisdholt merged 6 commits intomasterfrom May 14, 2020
Merged
feat: initial work to update the fast-components design system#3135chrisdholt merged 6 commits intomasterfrom
chrisdholt merged 6 commits intomasterfrom
Conversation
chrisdholt
requested review from
EisenbergEffect,
janechu and
nicholasrice
as code owners
| "#151515", | ||
| "#121212", | ||
| "#101010", | ||
| "#000000" |
Contributor
There was a problem hiding this comment.
Something is going on with these trailling commas - I see some PRs removing them and some adding them.
Collaborator
There was a problem hiding this comment.
I'm guessing it's a prettier mismatch, @chrisdholt can you try updating?
EisenbergEffect
approved these changes
May 14, 2020
Contributor
EisenbergEffect
left a comment
EisenbergEffect
left a comment
There was a problem hiding this comment.
Just a question about what seems an unnecessary calc otherwise looks good.
janechu
approved these changes
May 14, 2020
chrisdholt
force-pushed
the
users/chhol/update-fast-components-design-system
branch
from
5676e1f to
7c986ea
Compare
eljefe223
approved these changes
May 14, 2020
chrisdholt
force-pushed
the
users/chhol/update-fast-components-design-system
branch
from
7c986ea to
6ad32f7
Compare
chrisdholt
force-pushed
the
users/chhol/update-fast-components-design-system
branch
from
6ad32f7 to
434c090
Compare
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
chrisdholt
added a commit
that referenced
this pull request
May 18, 2020
* update design system colors and remove elevated corner radius * update storybook theme to include custom css to ensure accurate visuals * fix hypertext styles * update preview styles and dialog styles for corner radius * update accent color * comment failings tests per nicholasrice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the initial work to update the fast-components design system. Related to #3088
Motivation & context
Issue type checklist
Is this a breaking change?
Process & policy checklist