chore: remove legacy globalThis polyfill#7481
Merged
janechu merged 3 commits intoreleases/fast-element-v3from Apr 23, 2026
Merged
chore: remove legacy globalThis polyfill#7481janechu merged 3 commits intoreleases/fast-element-v3from
janechu merged 3 commits intoreleases/fast-element-v3from
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
94fcc72 to
a4ba73f
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chrisdholt
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
globalThispolyfill from@microsoft/fast-elementwhilekeeping the
requestIdleCallback/cancelIdleCallbackfallback.README.md,DESIGN.md,MIGRATION.md, and the 3.x browser support page.🎫 Issues
👩💻 Reviewer Notes
packages/fast-element/src/polyfills.ts; the remaining edits aredocumentation, migration guidance, the change file, and generated size docs.
npm run teststill hits an existing@microsoft/fast-htmlnested-elementsfailure on this branch, andnpm run test -w @microsoft/fast-elementstill sees existing Playwrightconnection-refused / flaky failures unrelated to this polyfill removal.
📑 Test Plan
npm run buildnpm run biome:checknpm run checkchangenode --input-type=module -e "delete globalThis.requestIdleCallback; delete globalThis.cancelIdleCallback; await import('./packages/fast-element/dist/esm/polyfills.js'); console.log(typeof globalThis.requestIdleCallback, typeof globalThis.cancelIdleCallback);"npm run test(currently fails in pre-existingpackages/fast-html/test/fixtures/scenarios/nested-elements/nested-elements.spec.ts)npm run test -w @microsoft/fast-element(currently fails in existing Playwright instability /ERR_CONNECTION_REFUSEDcases on this branch)✅ Checklist
General
$ npm run change