Skip to content

chore: remove legacy globalThis polyfill#7481

Merged
janechu merged 3 commits intoreleases/fast-element-v3from
users/janechu/remove-global-this
Apr 23, 2026
Merged

chore: remove legacy globalThis polyfill#7481
janechu merged 3 commits intoreleases/fast-element-v3from
users/janechu/remove-global-this

Conversation

@janechu
Copy link
Copy Markdown
Collaborator

@janechu janechu commented Apr 22, 2026

Pull Request

📖 Description

  • Remove the legacy globalThis polyfill from @microsoft/fast-element while
    keeping the requestIdleCallback / cancelIdleCallback fallback.
  • Document the new v3 runtime expectation in README.md, DESIGN.md,
    MIGRATION.md, and the 3.x browser support page.
  • Regenerate the fast-element size docs to capture the smaller bundle output.

🎫 Issues

👩‍💻 Reviewer Notes

  • The only runtime code change is in
    packages/fast-element/src/polyfills.ts; the remaining edits are
    documentation, migration guidance, the change file, and generated size docs.
  • npm run test still hits an existing @microsoft/fast-html
    nested-elements failure on this branch, and
    npm run test -w @microsoft/fast-element still sees existing Playwright
    connection-refused / flaky failures unrelated to this polyfill removal.

📑 Test Plan

  • npm run build
  • npm run biome:check
  • npm run checkchange
  • node --input-type=module -e "delete globalThis.requestIdleCallback; delete globalThis.cancelIdleCallback; await import('./packages/fast-element/dist/esm/polyfills.js'); console.log(typeof globalThis.requestIdleCallback, typeof globalThis.cancelIdleCallback);"
  • npm run test (currently fails in pre-existing packages/fast-html/test/fixtures/scenarios/nested-elements/nested-elements.spec.ts)
  • npm run test -w @microsoft/fast-element (currently fails in existing Playwright instability / ERR_CONNECTION_REFUSED cases on this branch)

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu added fast-element-v3 Pertains to fast-element-v3 labels Apr 22, 2026
janechu and others added 2 commits April 22, 2026 16:51
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@janechu janechu force-pushed the users/janechu/remove-global-this branch from 94fcc72 to a4ba73f Compare April 22, 2026 23:55
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@janechu janechu marked this pull request as ready for review April 23, 2026 00:00
@janechu janechu merged commit bd4550a into releases/fast-element-v3 Apr 23, 2026
13 checks passed
@janechu janechu deleted the users/janechu/remove-global-this branch April 23, 2026 02:04
@janechu janechu mentioned this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-element-v3 Pertains to fast-element-v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants