Skip to content

fix: keep fast-element exports explicit#7485

Closed
janechu wants to merge 2 commits intoreleases/fast-element-v3from
users/janechu/update-exports
Closed

fix: keep fast-element exports explicit#7485
janechu wants to merge 2 commits intoreleases/fast-element-v3from
users/janechu/update-exports

Conversation

@janechu
Copy link
Copy Markdown
Collaborator

@janechu janechu commented Apr 23, 2026

Pull Request

📖 Description

  • keep optional binding and hydration export paths separate instead of collapsing them into binding.js / hydration.js
  • remove wildcard barrel re-exports from fast-element secondary entrypoints by making index.debug.ts, index.rollup.ts, and index.rollup.debug.ts explicit
  • remove the temporary package-exports regression test and the grouped binding/exports.ts / hydration/exports.ts source files
  • keep metadata.js and pending-task.js out of the public export map
  • update docs, examples, skills, and generated export-size docs to reflect the dedicated subpaths

🎫 Issues

👩‍💻 Reviewer Notes

  • declarative.ts continues to own the hydratable-template side effect via the existing side-effect import
  • install-element-hydration.js and install-hydratable-view-templates.js stay as dedicated side-effect entrypoints
  • npm run checkchange reports that no new change files are needed

📑 Test Plan

  • npm run build
  • npm run prebuild -w sites/website
  • npm run biome:check
  • npm run checkchange
  • npx playwright test src/components/hydration.pw.spec.ts src/components/element-controller.pw.spec.ts --project=chromium

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

janechu and others added 2 commits April 23, 2026 13:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@janechu janechu changed the title fix: consolidate fast-element export entrypoints fix: keep fast-element exports explicit Apr 23, 2026
@janechu
Copy link
Copy Markdown
Collaborator Author

janechu commented Apr 23, 2026

Abandoning this, context was lost due to a misunderstanding of barrel exports.

@janechu janechu closed this Apr 23, 2026
@janechu janechu deleted the users/janechu/update-exports branch April 23, 2026 21:39
@janechu janechu mentioned this pull request Apr 24, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant