-
Notifications
You must be signed in to change notification settings - Fork 50
feat: add http.route attribute to open telemetry on requests #640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ea4c914
feat: add http.route attribute to open telemetry on requests
gavinbarron 50b1e7a
expanded tests to include some coverage of existing otel instrumentation
gavinbarron 03f0e6e
Potential fix for pull request finding 'Missing Dispose call on local…
baywet f0171bd
Apply suggestions from code review
baywet ba384ac
Update tests/http/httpClient/HttpClientRequestAdapterObservabilityTes…
baywet 0ea0d30
Fix HttpResponseMessage disposal in Moq test setups (#645)
Copilot 02a02fe
Wrap HttpResponseMessage instantiation with lambda in Moq ReturnsAsyn…
Copilot 2a13ceb
Fix HttpResponseMessage disposal in mock test setups (#642)
Copilot 4acdcbe
Fix HttpResponseMessage disposal in mock test setups (#643)
Copilot bc39434
Fix mock response content-type in observability tests (#646)
Copilot 7f91f9b
chore: seals the test class because it implements IDisposable
baywet b7decc5
Fix observability test setup to use correct content type (#647)
Copilot 059cdca
chore: removes try catch from tests
baywet 3c9ecd6
Deduplicate baseUrlPlaceholder constant in GetNormalizedHttpRoute (#648)
Copilot b89ed9b
chore: fixes tests definitions
baywet a71f036
chore: formatting
baywet c0dde22
Mark IDisposable test classes as sealed (#649)
Copilot 0635ea9
Apply suggestion from @Copilot
baywet 22e4ffe
Merge branch 'main' into feat/add-otel-http.route
gavinbarron 0a74985
cleaned up tests to theories and fixed missing query string cases
gavinbarron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.